Skip to content

[Forwardport] Correct return type of methods and typo correction.#16224

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
saurabh-parekh:2.3-develop-PR-port-15993
Jun 21, 2018
Merged

[Forwardport] Correct return type of methods and typo correction.#16224
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
saurabh-parekh:2.3-develop-PR-port-15993

Conversation

@saurabh-parekh
Copy link
Copy Markdown

Original Pull Request

#15993

Description

Correct return type of methods and change return type.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @saurabh-aureate. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @saurabh-aureate. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants